Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct electron-to-proton ratios and mean molecular masses for different abundance tables #1290

Open
DavidT3 opened this issue Nov 29, 2024 · 0 comments
Assignees
Labels
refinement If a feature has already been implemented, and works, but could do with another pass to improve it.

Comments

@DavidT3
Copy link
Owner

DavidT3 commented Nov 29, 2024

Currently the only added electron-to-proton ratio is for Anders and Grevasse (angr), though I did write XGA so other values of e-to-p for other tables could be added (just never really did).

Figured out (I'm pretty sure) how to calculate e-to-p and mean mol weight:

https://gist.github.com/DavidT3/438bc58ed23fbbbb9f02c9d61f66248e

So will include that - those values assume a typical metallicity of 0.3 though, so maybe should add a function that calculates for an input tables and metallicity.

I don't think the mean molecular weight is currently set up to allow different values for different tables, so will need to change that.

@DavidT3 DavidT3 added the refinement If a feature has already been implemented, and works, but could do with another pass to improve it. label Nov 29, 2024
@DavidT3 DavidT3 self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refinement If a feature has already been implemented, and works, but could do with another pass to improve it.
Projects
None yet
Development

No branches or pull requests

1 participant