From f86f230fabe91519ea4acc744337a69123995dcf Mon Sep 17 00:00:00 2001 From: ConorDavenport Date: Fri, 14 Feb 2020 12:54:11 +0000 Subject: [PATCH] doc: update cpp style guide file naming and fix links Updated cpp style guide file name and location and fixed links to this file. Fixes: https://github.com/nodejs/node/issues/31741 --- doc/guides/contributing/pull-requests.md | 2 +- CPP_STYLE_GUIDE.md => doc/guides/cpp-style-guide.md | 0 src/README.md | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename CPP_STYLE_GUIDE.md => doc/guides/cpp-style-guide.md (100%) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 7f4ab4e83e049b..63af5a055c5756 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -121,7 +121,7 @@ in the API docs will also be checked when running `make lint` (or use `REPLACEME` for the version number in the documentation YAML. For contributing C++ code, you may want to look at the -[C++ Style Guide](../../../CPP_STYLE_GUIDE.md), as well as the +[C++ Style Guide](../../cpp-style-guide.md), as well as the [README of `src/`](../../../src/README.md) for an overview over Node.js C++ internals. diff --git a/CPP_STYLE_GUIDE.md b/doc/guides/cpp-style-guide.md similarity index 100% rename from CPP_STYLE_GUIDE.md rename to doc/guides/cpp-style-guide.md diff --git a/src/README.md b/src/README.md index 40790b278acb65..2e59c51c3c37e9 100644 --- a/src/README.md +++ b/src/README.md @@ -903,7 +903,7 @@ static void GetUserInfo(const FunctionCallbackInfo& args) { [`v8.h` in Node.js master]: https://github.com/nodejs/node/blob/master/deps/v8/include/v8.h [`v8.h` in V8 master]: https://github.com/v8/v8/blob/master/include/v8.h [`vm` module]: https://nodejs.org/api/vm.html -[C++ coding style]: ../CPP_STYLE_GUIDE.md +[C++ coding style]: ../doc/guides/cpp-style-guide.md [Callback scopes]: #callback-scopes [JavaScript value handles]: #js-handles [N-API]: https://nodejs.org/api/n-api.html