Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Add support for global variables from test #831

Merged
merged 7 commits into from
Jan 14, 2021
Merged

[Synthetics] Add support for global variables from test #831

merged 7 commits into from
Jan 14, 2021

Conversation

romainberger
Copy link
Member

No description provided.

@romainberger romainberger force-pushed the rberger/SYA-542/synthetics-vft branch from ef2131b to 8b10b09 Compare January 11, 2021 10:45
@romainberger romainberger marked this pull request as ready for review January 11, 2021 10:46
@romainberger romainberger requested review from a team as code owners January 11, 2021 10:46
sdeprez
sdeprez previously approved these changes Jan 11, 2021
View reviewed changes
@romainberger
Copy link
Member Author

romainberger commented Jan 11, 2021 •
edited
Loading

Please wait before merging, it needs a fix from https://github.com/DataDog/datadog-api-spec/pull/759

Good to merge when approved.

@romainberger romainberger mentioned this pull request Jan 11, 2021
Merged
@romainberger romainberger force-pushed the rberger/SYA-542/synthetics-vft branch from 8b10b09 to 7a7956e Compare January 12, 2021 09:31
@romainberger
Copy link
Member Author

Good to merge when approved.

therve
therve requested changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise looks good.

datadog/resource_datadog_synthetics_global_variable_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_synthetics_global_variable_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_synthetics_global_variable.go Show resolved Hide resolved
@therve
Copy link
Contributor

therve commented Jan 14, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve merged commit b0fb1e2 into master Jan 14, 2021
@therve therve deleted the rberger/SYA-542/synthetics-vft branch January 14, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

@sdeprez sdeprez sdeprez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romainberger @therve @sdeprez