Store dashboard widget IDs #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new attribute to dashboard widgets to store their IDs for future references. Closes #301
zippolyte
approved these changes
Jan 6, 2021
matt-miller-ddog
approved these changes
Jan 6, 2021
| @@ -540,6 +540,11 @@ func getNonGroupWidgetSchema() map[string]*schema.Schema { | |||
| Schema: getWidgetLayoutSchema(), | |||
| }, | |||
| }, | |||
| "id": { | |||
| Type: schema.TypeInt, | |||
| Computed: true, | |||
There was a problem hiding this comment.
👍 for computed: true
| @@ -540,6 +540,11 @@ func getNonGroupWidgetSchema() map[string]*schema.Schema { | |||
| Schema: getWidgetLayoutSchema(), | |||
| }, | |||
| }, | |||
| "id": { | |||
| Type: schema.TypeInt, | |||
There was a problem hiding this comment.
We've had some trouble in the past with widget IDs big enough to require Int64 when represented in Go. I think schema.TypeInt will work (they don't seem to provide an explicitly Int64 version) but I'm not familiar enough to gauge this properly.
Just wanted to put this on your radar.
There was a problem hiding this comment.
Thanks for the comment: terraform does indeed the right thing, and TypeInt is int64 capable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new attribute to dashboard widgets to store their IDs for
future references.
Closes #301