Add support for basicAuth and query in Synthetics resource #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds 2 requests fields that we didn't expose previously. As `request_headers`, this needs to be outside of the `request` attribute but it only supports basic types.
ghost
added
therve
changed the title
zippolyte
approved these changes
Jul 21, 2020
jirikuncar
approved these changes
Jul 21, 2020
sdeprez
reviewed
Jul 21, 2020
| @@ -125,6 +125,10 @@ The following arguments are supported: | |||
| - `method` - (Required) no-op, use GET | |||
| - `url` - (Required) Any url | |||
| - `request_headers` - (Optional) Header name and value map | |||
| - `request_query` - (Optional) Query arguments name and value map | |||
| - `request_basicauth` - (Optional) Array of 1 item containing HTTP basic authentication credentials | |||
There was a problem hiding this comment.
Why is it an array of one item and not the item directly?
Comment on lines
+52
to
+56
| "request_query": { | ||
| Type: schema.TypeMap, | ||
| Optional: true, | ||
| }, | ||
| "request_basicauth": { |
There was a problem hiding this comment.
For my knowledge, you said As request_headers, this needs to be outside of the request but why?
sdeprez
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 2 requests fields that we didn't expose previously. As
request_headers, this needs to be outside of therequestattribute but it only supports basic types.Closes #305