Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terraform sdk + cli versions to user agent header #455

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Add terraform sdk + cli versions to user agent header #455

merged 3 commits into from
Mar 20, 2020

Conversation

nmuesch
Copy link
Contributor

@nmuesch nmuesch commented Mar 19, 2020 •
edited
Loading

This PR includes a couple extra pieces of info about the running terraform version in the user agent header:

  • The Terraform SDK version (This is vendored into the provider, so this could be extracted indirectly by knowing the provider version, but this explicitly includes it)
  • The terraform CLI version used to invoke the provider.

Inspiration from - https://github.com/terraform-providers/terraform-provider-oci/blob/8ed6736016dfc4ee36cb77c80ea7f519ae2c84f4/oci/provider.go#L958
SDK Meta version from the meta package - https://github.com/hashicorp/terraform-plugin-sdk/blob/dbee9ba9e9bca050f5fa5d56d3232eefc64e44be/meta/meta.go

@ghost ghost added the size/XS label Mar 19, 2020
nmuesch
nmuesch commented Mar 19, 2020
View reviewed changes
datadog/provider.go Outdated Show resolved Hide resolved
@nmuesch nmuesch merged commit fc6c1d8 into DataDog:master Mar 20, 2020
@nmuesch nmuesch deleted the nick/ua branch March 20, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmuesch @jirikuncar