Hide deprecated monitor summary widget params #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and deprecate them
ghost
added
enbashi
reviewed
Feb 4, 2020
bkabrda
suggested changes
Feb 4, 2020
| @@ -2355,10 +2355,12 @@ func getManageStatusDefinitionSchema() map[string]*schema.Schema { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| }, | |||
| // The count param is deprecated | |||
There was a problem hiding this comment.
Could you please add the Deprecated attribute to these two? https://godoc.org/github.com/hashicorp/terraform/helper/schema#Schema
|
LGTM now, merging. Thanks for the PR! |
bkabrda
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the count and start monitor summary widget params from the docs and deprecate them.
While these params are still supported (and will continue to be), they don't appear to be used by anyone and we don't know of any use cases for them, so we should remove them from the docs to avoid confusion.
Related: https://github.com/terraform-providers/terraform-provider-datadog/pull/300 (the
sortparam does have use cases so we're adding it to the docs here: DataDog/documentation#6568).