Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'count' as valid aggregation method #333

Merged
merged 1 commit into from
Oct 10, 2019
Merged

add 'count' as valid aggregation method #333

merged 1 commit into from
Oct 10, 2019

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Oct 3, 2019

Picks up where we left off in #129

@ghost ghost added the size/S label Oct 3, 2019
nmuesch
nmuesch approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks! CC @enbashi could you take a quick look here too please?

@dabcoder dabcoder mentioned this pull request Oct 3, 2019
Closed
enbashi
enbashi approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@enbashi enbashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nmuesch nmuesch merged commit 42473c8 into DataDog:master Oct 10, 2019
@dabcoder dabcoder deleted the davidb/count branch October 10, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmuesch nmuesch nmuesch approved these changes

@enbashi enbashi enbashi approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dabcoder @enbashi @nmuesch @masci