Support Logs Index API #326
Conversation
tt810
commented
Sep 25, 2019
tt810
commented
- Resource for index and tests
- Resource for index order and tests
- Documentation
ghost
added
|
|
||
| ## Example Usage | ||
|
|
||
| Create a Datadog logs pipeline order resource |
There was a problem hiding this comment.
Can we put this as a comment in the sample code rather than up here?
There was a problem hiding this comment.
I was trying to make it look similar to logs_pipeline. Do you think I should update both of them (pipeline and index)?
There was a problem hiding this comment.
Yup, let's either put it in as a comment in the sample code or just remove it altogether (I don't think it's adding too much value TBH).
There was a problem hiding this comment.
Sounds good. I will remove this line for both index_order and pipeline_order.
| return nil | ||
| } | ||
|
|
||
| func resourceDatadogLogsIndexOrderExists(d *schema.ResourceData, meta interface{}) (bool, error) { |
There was a problem hiding this comment.
Would have been nice to explain with a comment why we always return true here
| return nil | ||
| } | ||
|
|
||
| func resourceDatadogLogsIndexOrderDelete(d *schema.ResourceData, meta interface{}) error { |
There was a problem hiding this comment.
Same, a comment on why we don't need the delete method would have been nice.
| return resourceDatadogLogsIndexRead(d, meta) | ||
| } | ||
|
|
||
| func resourceDatadogLogsIndexDelete(d *schema.ResourceData, meta interface{}) error { |
| return ddEFilters | ||
| } | ||
|
|
||
| func buildDatadogExclusionFilter(tfEFilter map[string]interface{}) datadog.ExclusionFilter { |
There was a problem hiding this comment.
nits: as a general remark, I think tfEFilter is not really explicit and I'd rather use full name, e.g. tfExclusionFiler. Same for tfFs.
