Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data source - IP ranges #298

Merged
merged 6 commits into from
Sep 30, 2019
Merged

Add data source - IP ranges #298

merged 6 commits into from
Sep 30, 2019

Conversation

dabcoder
Copy link
Contributor

Attempts to address #216.

@dabcoder dabcoder force-pushed the davidb/data-source-ips branch from d869ce3 to 7be7bcb Compare September 16, 2019 12:13
@dabcoder dabcoder marked this pull request as ready for review September 16, 2019 12:32
bkabrda
bkabrda suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dabcoder, this looks really great! I only left one minor comment/question inline, but when we figure that one out, I can approve this.

datadog/data_source_datadog_ip_ranges.go Outdated Show resolved Hide resolved
bkabrda
bkabrda approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, merging. Thanks a lot for doing this!

@bkabrda bkabrda merged commit 8809a23 into DataDog:master Sep 30, 2019
@bkabrda bkabrda mentioned this pull request Sep 30, 2019
Closed
@dabcoder dabcoder deleted the davidb/data-source-ips branch September 30, 2019 15:02
@mechastorm mechastorm mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkabrda bkabrda bkabrda approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dabcoder @bkabrda