Add dashboard list resource #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
nmuesch
commented
Aug 22, 2019
| @@ -32,19 +32,20 @@ func Provider() terraform.ResourceProvider { | |||
| }, | |||
|
|
|||
| ResourcesMap: map[string]*schema.Resource{ | |||
| "datadog_downtime": resourceDatadogDowntime(), | |||
There was a problem hiding this comment.
Alphabetized while I was here...
|
This PR requires - https://github.com/terraform-providers/terraform-provider-datadog/pull/297 to be merged before CI will pass. |
gzussa
reviewed
Aug 29, 2019
| id, _ := strconv.Atoi(d.Id()) | ||
| // Deleting the overall List will also take care of deleting its sub elements | ||
| // Deletion of individual dash items happens in the Update method | ||
| // Note this doesn't delete the actual dashboards, just removes them from the deleted list |
There was a problem hiding this comment.
I don't understand this note
There was a problem hiding this comment.
Just mentioning that you don't have to delete each individual dashboard from the list, deleting the list itself is enough.
| "dash_id": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| Description: "The list of dashboard IDs to add", |
There was a problem hiding this comment.
is this a list of ids or just one id?
There was a problem hiding this comment.
I recall that trying to make this a list made the provider code really complex. But I see I forgot to update the description, will fix that 😄
gzussa
approved these changes
Aug 29, 2019
bkabrda
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new dashboard list resource.