[Synthetics] Support SSL #279
Merged
+331
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
btoueg
commented
Aug 7, 2019
•
btoueg
commented
- Add support for ssl tests
- Add acceptance test
- Update doc
- Have subtype defaults to http for api tests
- Make sure existing TF files won't diff
ghost
added
|
Hey @btoueg thanks for the PR! The golang client was released + bumped in this provider. Can you rebase from master and we can work on getting this reviewed? |
nmuesch
requested changes
Aug 12, 2019
| @@ -316,6 +359,9 @@ func newSyntheticsTestFromLocalState(d *schema.ResourceData) *datadog.Synthetics | |||
| minLocationFailed, _ := strconv.Atoi(attr.(string)) | |||
| options.SetMinLocationFailed(minLocationFailed) | |||
| } | |||
| if attr, ok := d.GetOk("options.accept_self_signed"); ok { | |||
| options.SetAcceptSelfSigned(attr.(string) == "true") | |||
There was a problem hiding this comment.
Any reason not to just assign this to attr.(string) Should we also safely type assert this?
There was a problem hiding this comment.
Not sure, can't wrap my head around it. It's value is "1" or "0" in TF 0.11, even though is never set to such value
Indeed, that's the case in TF 0.11. I've handled it, let me know |
|
Thanks for the iterations here! Looks good to me, I'll go ahead and merge. Thanks for this 🎉🚀 |
nmuesch
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.