[dashboards] Add resources for log, apm and process query in legacy dashboards #272
+1,078
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
jbenais
changed the title
jbenais
force-pushed
the
julia/log-apm-process-query-legacy-api
branch
from
253a5ff to
48d1b66
Compare
jbenais
changed the title
enbashi
requested changes
Aug 2, 2019
There was a problem hiding this comment.
I added some inline comments. Additionally:
- The read part is missing in screenboards resource. To verify this is working as expected, we need to run
importcommand https://www.terraform.io/docs/providers/datadog/r/screenboard.html#import and verify the internal state contains the correct values. - Let's add some tests for the new params.
jbenais
force-pushed
the
julia/log-apm-process-query-legacy-api
branch
5 times, most recently
from
a97405d to
d504d65
Compare
enbashi
requested changes
Aug 7, 2019
|
Hey @jbenais thanks for the PR! The golang client was released + bumped in this provider. Can you rebase from master and we can work on getting this reviewed? |
jbenais
force-pushed
the
julia/log-apm-process-query-legacy-api
branch
from
6a97922 to
bd9f4e2
Compare
nmuesch
requested changes
Aug 20, 2019
jbenais
force-pushed
the
julia/log-apm-process-query-legacy-api
branch
4 times, most recently
from
7b655c3 to
3b451db
Compare
nmuesch
reviewed
Aug 21, 2019
There was a problem hiding this comment.
🚀 Looks good to me. Ran some manual applies and seems to work well there.
Left a really small comment about what looks like a typo, should be a super quick thing. Lets get a release going on the go client so we can remove the vendor changes and get this merged 🎉
jbenais
force-pushed
the
julia/log-apm-process-query-legacy-api
branch
from
a515ea6 to
5afda25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality relies on a change in the Go client that is in a merged PR: zorkian/go-datadog-api#251