-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using accessors, adding err checks #27
Conversation
* Most calls to `schema.ResourceData.Set` failed to check returned error, surpressing actual errors * Zorkian's `go-datadog-api.v2` uses accessor methods and not all the provider code was updated * Switched to using kr/pretty logging to dump objects during debug
I could go either way on using the |
I just tested this and now changes in the UI are reflected in terraform plan (reverting manual changes back to the expected state). @radeksimko @grubernaut @stack72 I'd love to get this merged and tagged with a new version (0.1.1?). Pinging for review |
@radeksimko @grubernaut @stack72 This is a hugely important bug-fix. Don't mean to be annoying, but can we get a review and either merge or some feedback on what needs to change? As an aside, if this repo is not one that you're keen on maintaining (lack of visibility, don't use datadog, or lack of interest), I'd be willing to discuss getting additional people write access to this repo. If that's something that you're interested in, let me know. |
Hey @nyanshak, sorry this hasn't been merged for you yet. Although @stack72 and myself are no longer employees at HashiCorp. @catsby, @tombuildsstuff, and @apparentlymart are though! |
My bad! I was going based off most recently merged commits :'( Sorry |
schema.ResourceData.Set
failed to check returned error, surpressing actual errorsgo-datadog-api.v2
uses accessor methods and not all the provider code was updatedschema.TypeSet
toschema.TypeList
, there were errors that were resolved by moving toTypeList
. I don't know if this was the right path, maybe we could revisit making these sets in the future. Errors were like this: