Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using accessors, adding err checks #27

Merged
merged 9 commits into from Oct 19, 2017
Merged

Using accessors, adding err checks #27

merged 9 commits into from Oct 19, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2017

* module.datadog_timeboard.my_timeboard: datadog_timeboard.my_timeboard: Invalid address to set: []string{"graph", "2", "scope"}

Kurt Scherer added 7 commits October 3, 2017 12:49
* Most calls to `schema.ResourceData.Set` failed to check returned error, surpressing actual errors
* Zorkian's `go-datadog-api.v2` uses accessor methods and not all the provider code was updated
* Switched to using kr/pretty logging to dump objects during debug
@ghost
Copy link
Author

ghost commented Oct 3, 2017

I could go either way on using the kr/pretty package, if anyone is against it. I just find it easier to have better reflection when dumping objects during debugging.

@radeksimko radeksimko added the bug label Oct 4, 2017
@nyanshak
Copy link
Contributor

nyanshak commented Oct 5, 2017

I just tested this and now changes in the UI are reflected in terraform plan (reverting manual changes back to the expected state).

@radeksimko @grubernaut @stack72 I'd love to get this merged and tagged with a new version (0.1.1?). Pinging for review

@nyanshak
Copy link
Contributor

@radeksimko @grubernaut @stack72

This is a hugely important bug-fix. Don't mean to be annoying, but can we get a review and either merge or some feedback on what needs to change?

As an aside, if this repo is not one that you're keen on maintaining (lack of visibility, don't use datadog, or lack of interest), I'd be willing to discuss getting additional people write access to this repo. If that's something that you're interested in, let me know.

@grubernaut
Copy link
Contributor

Hey @nyanshak, sorry this hasn't been merged for you yet. Although @stack72 and myself are no longer employees at HashiCorp. @catsby, @tombuildsstuff, and @apparentlymart are though!

@nyanshak
Copy link
Contributor

nyanshak commented Oct 13, 2017

My bad! I was going based off most recently merged commits :'( Sorry

@apparentlymart apparentlymart merged commit 5500d18 into DataDog:master Oct 19, 2017
@apparentlymart
Copy link
Contributor

Thanks for this @yfronto, @nyanshak!

Sorry for the delay in reviewing this. We're about to head into the next major release period and so we've been more heads-down than usual, unfortunately. 😖

nitrocode pushed a commit to nitrocode/terraform-provider-datadog that referenced this pull request Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants