Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to the threshold_windows #260

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Conversation

heldersepu
Copy link
Contributor

@heldersepu heldersepu commented Jul 14, 2019

This fixes issue #259
The threshold_windows should be added only if a window has been set

The Options structure already has the flag to omit it when it is empty:

type Options struct {
        ...
	EscalationMessage *string           `json:"escalation_message,omitempty"`
	Thresholds        *ThresholdCount   `json:"thresholds,omitempty"`
	ThresholdWindows  *ThresholdWindows `json:"threshold_windows,omitempty"`
	IncludeTags       *bool             `json:"include_tags,omitempty"`
        ...
}

threshold_windows should be added only if a window has been set
@ghost ghost added the size/XS label Jul 14, 2019
@ghost ghost added size/S and removed size/XS labels Jul 14, 2019
@bkabrda
Copy link
Contributor

bkabrda commented Jul 15, 2019

Looks perfect 👍 Thank you very much for the contribution! Merging.

@bkabrda bkabrda merged commit f43eac5 into DataDog:master Jul 15, 2019
@heldersepu
Copy link
Contributor Author

Wow! Thanks, @bkabrda that was quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants