[Synthetics] Fix follow redirects

[btoueg]

Considering:

• TF nested schemas is limited to string values
• follow_redirects is a boolean in Datadog json api

we need to convert boolean like this:

• true => "true"
• false => "false"

☝️better because follow_redirects is advertised as a boolean in the documentation so this PR:

• enforces that its set as a boolean value in the config,
• In TF 0.12.x the diff is improperly shown as going from a number to a boolean (i.e. 0/1 -> true/false) even if there was no diff. This worked fine in TF 0.11
• Fixes ^ by converting any non bool values to bool

[gabsn]

@btoueg Did you run the acceptance tests? I'm very surprised nothing is broken whereas you did modify the schema itself. Also can you add a test on options too?

[btoueg]

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-datadog       [no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatadogScreenboard_update
--- PASS: TestAccDatadogScreenboard_update (9.37s)
=== RUN   TestAccDatadogSyntheticsAPITest_importBasic
=== PAUSE TestAccDatadogSyntheticsAPITest_importBasic
=== RUN   TestAccDatadogSyntheticsBrowserTest_importBasic
=== PAUSE TestAccDatadogSyntheticsBrowserTest_importBasic
=== RUN   TestAccDatadogSyntheticsAPITest_Basic
--- PASS: TestAccDatadogSyntheticsAPITest_Basic (7.35s)
=== RUN   TestAccDatadogSyntheticsAPITest_Updated
--- PASS: TestAccDatadogSyntheticsAPITest_Updated (12.94s)
=== RUN   TestAccDatadogSyntheticsBrowserTest_Basic
--- PASS: TestAccDatadogSyntheticsBrowserTest_Basic (7.20s)
=== RUN   TestAccDatadogSyntheticsBrowserTest_Updated
--- PASS: TestAccDatadogSyntheticsBrowserTest_Updated (12.57s)
=== CONT  TestAccDatadogSyntheticsAPITest_importBasic
=== CONT  TestAccDatadogSyntheticsBrowserTest_importBasic
--- PASS: TestAccDatadogSyntheticsAPITest_importBasic (7.83s)
--- PASS: TestAccDatadogSyntheticsBrowserTest_importBasic (7.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-datadog/datadog       57.286s

[nmuesch]

Thanks for this PR! Left a few comments, mostly about seeing if we can use ParseBool as I think it'll reduce the complexity here. Let me know what you think.

[nmuesch]

Could we use parseBool here too - https://golang.org/pkg/strconv/#ParseBool
If that function returns doesn't return an error then this validation passes?

[btoueg]

ParseBool does not fit my use case here, but I rewrote it with a switch à la ParseBool

[btoueg]

TIL ParseBool thanks!

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-datadog       [no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatadogScreenboard_update
--- PASS: TestAccDatadogScreenboard_update (8.04s)
=== RUN   TestAccDatadogSyntheticsAPITest_importBasic
=== PAUSE TestAccDatadogSyntheticsAPITest_importBasic
=== RUN   TestAccDatadogSyntheticsBrowserTest_importBasic
=== PAUSE TestAccDatadogSyntheticsBrowserTest_importBasic
=== RUN   TestAccDatadogSyntheticsAPITest_Basic
--- PASS: TestAccDatadogSyntheticsAPITest_Basic (5.90s)
=== RUN   TestAccDatadogSyntheticsAPITest_Updated
--- PASS: TestAccDatadogSyntheticsAPITest_Updated (10.46s)
=== RUN   TestAccDatadogSyntheticsBrowserTest_Basic
--- PASS: TestAccDatadogSyntheticsBrowserTest_Basic (6.98s)
=== RUN   TestAccDatadogSyntheticsBrowserTest_Updated
--- PASS: TestAccDatadogSyntheticsBrowserTest_Updated (10.52s)
=== CONT  TestAccDatadogSyntheticsAPITest_importBasic
=== CONT  TestAccDatadogSyntheticsBrowserTest_importBasic
--- PASS: TestAccDatadogSyntheticsAPITest_importBasic (6.09s)
--- PASS: TestAccDatadogSyntheticsBrowserTest_importBasic (6.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-datadog/datadog       48.537s```

[nmuesch]

As we chatted about offline, this type assertion causes an issue on TF 0.11 (works fine in 0.12) Lets try to convert this value into a string if possible to avoid breaking things.

[nmuesch]

Overall looks good to me and seems to work for TF 0.11 and 0.12, thanks for that. Currently it looks like the user shown diff is:

  ~ datadog_synthetics_test.test_synth
      options.follow_redirects: "false" => "1"

But there doesn't appear to be any issues with spurious non-empty diffs.

Though @btoueg since we learned that from the first point TF nested schemas is limited to string values actually can be boolean/int values and are just strings in the state, is this change explicitly needed then?

[nmuesch]

Discussed offline. The diff in 0.12 is:

"follow_redirects" = "true" -> "false"