Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert window query arg must match trigger window monitor option #246

Closed
cohandv opened this issue Jun 24, 2019 · 4 comments
Closed

alert window query arg must match trigger window monitor option #246

cohandv opened this issue Jun 24, 2019 · 4 comments

Comments

@cohandv
Copy link

cohandv commented Jun 24, 2019

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

Terraform v0.11.8

  • provider.aws v2.16.0
  • provider.datadog v2.0.1
  • provider.null v2.1.2
  • provider.template v2.1.2

Affected Resource(s)

  • datadog_monitor

Terraform Configuration Files

Debug Output

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform apply

References

Documentation states that the parameter is optional: https://www.terraform.io/docs/providers/datadog/r/monitor.html#trigger_window

@cohandv
Copy link
Author

cohandv commented Jun 24, 2019

terraform.txt

Output of debug attached

@nmuesch
Copy link
Contributor

nmuesch commented Jun 27, 2019

Hey @cohandv Thanks for the issue report. Could you share the terraform config you are using to trigger this behavior? The trigger_window option is required for anomaly monitors (I'm working on updating the docs to reflect that, apologies for the confusion)

If the issue is solely with the documentation, I'll share here when thats updated 😄

@cohandv
Copy link
Author

cohandv commented Jun 29, 2019

Hi @nmuesch thanks for replying, if this is the new behaviour, it's ok, I've been using this plugin with anomaly monitors at least from a year ago, and changed from version 1.9 and above. What I feel it's wrong is that the error is incorrect, if the argument is mandatory, it should say that, instead of failing when trying to create because it has assumed a value which is less than the one provided in the query.

@nmuesch
Copy link
Contributor

nmuesch commented Aug 13, 2019

Hey @cohandv apologies for the delay here. I agree this can definitely be confusing. The issue we have is that this field is only required for certain monitor types, so it's not something we can mark as required in the terraform schema, otherwise it would be considered required for all monitor types.

We recently updated the documentation to try to clarify this a bit - https://github.com/terraform-providers/terraform-provider-datadog/pull/252. I'll go ahead and close this issue for now but open to any feedback/suggestions. Thanks again and apologies for the troubles!

@nmuesch nmuesch closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants