-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement monitor_id support for downtime #18
Conversation
I'd suggest also changing the docs to mention this new (optional?) field: https://github.com/terraform-providers/terraform-provider-datadog/blob/master/website/docs/r/downtime.html.markdown. Also, I think you should check for errors on Sets, similar to @yfronto's proposed change (#27):
Otherwise, LGTM :) |
Hey @nyanshak, thanks for looking into this. |
@nyanshak Could we please get this into the master? |
@HontoNoRoger HashiCorp manages this repo. I think @tombuildsstuff might be the right contact to ping on this. |
(I really wish I could get it merged into master but I don't have the right permissions. Sorry @HontoNoRoger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @cvbarros
Thanks for this PR - apologies for the delayed review here!
I've taken a look through and this LGTM - I've also run the test suite and the suite passes too 👍
Thanks!
Implement monitor_id support for downtime
This PR is a shot at trying to implement the
monitor_id
field for downtime.Since this is my first PR for terraform, please let me know if there are any hard mistakes, and I'll more than happy to work through them.