Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement monitor_id support for downtime #18

Merged
merged 3 commits into from
Jan 3, 2018

Conversation

cvbarros
Copy link
Contributor

@cvbarros cvbarros commented Sep 4, 2017

This PR is a shot at trying to implement the monitor_id field for downtime.
Since this is my first PR for terraform, please let me know if there are any hard mistakes, and I'll more than happy to work through them.

@nyanshak
Copy link
Contributor

I'd suggest also changing the docs to mention this new (optional?) field: https://github.com/terraform-providers/terraform-provider-datadog/blob/master/website/docs/r/downtime.html.markdown.

Also, I think you should check for errors on Sets, similar to @yfronto's proposed change (#27):

if err := d.Set("title", timeboard.GetTitle()); err != nil {
	return err
}

Otherwise, LGTM :)

@cvbarros
Copy link
Contributor Author

Hey @nyanshak, thanks for looking into this.
I fixed some problems with acceptance tests and implemented the changes you suggested.

@HontoNoRoger
Copy link

@nyanshak Could we please get this into the master?

@ghost
Copy link

ghost commented Dec 15, 2017

@HontoNoRoger HashiCorp manages this repo. I think @tombuildsstuff might be the right contact to ping on this.

@nyanshak
Copy link
Contributor

(I really wish I could get it merged into master but I don't have the right permissions. Sorry @HontoNoRoger)

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @cvbarros

Thanks for this PR - apologies for the delayed review here!

I've taken a look through and this LGTM - I've also run the test suite and the suite passes too 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

screen shot 2018-01-03 at 16 16 48

@tombuildsstuff tombuildsstuff merged commit ed44749 into DataDog:master Jan 3, 2018
tombuildsstuff added a commit that referenced this pull request Jan 3, 2018
nitrocode pushed a commit to nitrocode/terraform-provider-datadog that referenced this pull request Nov 3, 2018
Implement monitor_id support for downtime
nitrocode pushed a commit to nitrocode/terraform-provider-datadog that referenced this pull request Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants