Adds ThresholdWindows #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
The code LGTM 👍. Could you please extend |
|
Ping @DuskEagle could you add some tests as requested above? If not, I guess I'll just merge and add them myself in another PR. |
|
Hi 👋 |
|
Ok, there's no response from @DuskEagle, so I'll merge and write a simple test myself in a followup PR. |
This was referenced May 6, 2019
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
Adds ThresholdWindows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anomaly monitors allow for setting a "trigger_window" and "recovery_window" within a "threshold_windows" map, as mentioned in https://github.com/terraform-providers/terraform-provider-datadog/issues/73. This PR adds support for managing those values via Terraform.