-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support segmentio/kafka.go.v0 #293
Conversation
Can you please separate the unrelated changes in their own PR:
That'll make this PR easier to review & also will allow easier reverting of any individual part of this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship only once it references a tagged release of dd-trace-go.
Signed-off-by: Eliott Bouhana <[email protected]>
This reverts commit 2edb1d9.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 59.48% 59.90% +0.42%
==========================================
Files 160 161 +1
Lines 11503 11691 +188
==========================================
+ Hits 6842 7004 +162
- Misses 4162 4189 +27
+ Partials 499 498 -1
|
Adds support for instrumenting
segmentio/kafka.go.v0
Requires DataDog/dd-trace-go#2885