Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support segmentio/kafka.go.v0 #293

Merged
merged 25 commits into from
Nov 5, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Sep 24, 2024

Adds support for instrumenting segmentio/kafka.go.v0

Requires DataDog/dd-trace-go#2885

@rarguelloF rarguelloF changed the title wip: feat: support segmentio/kafka.go.v0 feat: support segmentio/kafka.go.v0 Sep 25, 2024
@rarguelloF rarguelloF marked this pull request as ready for review September 25, 2024 15:07
@rarguelloF rarguelloF requested a review from a team as a code owner September 25, 2024 15:07
@RomainMuller
Copy link
Contributor

Can you please separate the unrelated changes in their own PR:

  • The removal of -v
  • The renaming of Spans to Traces
  • The change of type of Meta and addition of Metrics
  • The use of t.Cleanup

That'll make this PR easier to review & also will allow easier reverting of any individual part of this change.

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship only once it references a tagged release of dd-trace-go.

@rarguelloF rarguelloF enabled auto-merge October 23, 2024 12:43
@rarguelloF rarguelloF added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@rarguelloF rarguelloF added this pull request to the merge queue Nov 5, 2024
@rarguelloF rarguelloF removed this pull request from the merge queue due to a manual request Nov 5, 2024
@rarguelloF rarguelloF added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit bfd6900 Nov 5, 2024
23 checks passed
@rarguelloF rarguelloF deleted the rarguellof/APPSEC-53289/segmentio-kafka branch November 5, 2024 13:15
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 86.17021% with 26 lines in your changes missing coverage. Please review.

Project coverage is 59.90%. Comparing base (e8e08e1) to head (71134fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...-tests/tests/segmentio_kafka.v0/segmentio_kafka.go 86.17% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   59.48%   59.90%   +0.42%     
==========================================
  Files         160      161       +1     
  Lines       11503    11691     +188     
==========================================
+ Hits         6842     7004     +162     
- Misses       4162     4189      +27     
+ Partials      499      498       -1     
Components Coverage Δ
Generators 76.98% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.13% <ø> (ø)
Toolexec Driver 70.64% <ø> (ø)
Aspects 71.56% <ø> (+0.28%) ⬆️
Injector 73.58% <ø> (+0.21%) ⬆️
Job Server 67.56% <ø> (-0.57%) ⬇️
Integration Test Suite 51.52% <86.17%> (+1.09%) ⬆️
Other 59.90% <86.17%> (+0.42%) ⬆️
Files with missing lines Coverage Δ
...-tests/tests/segmentio_kafka.v0/segmentio_kafka.go 86.17% <86.17%> (ø)

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants