Updates dummyTrustManager to use more supported security protocol #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some customers run JMXFetch on a host install where their own JVM is used. These JVMs may restrict the available security algorithms to exclude SSL which would lead to an error similar to this:
This PR changes our
dummyTrustManager
to useTLS
instead ofSSL
(allowing the JVM to pick the specific version of TLS supported), which should have wider support across JVMs.Also adds an
error
log specifying the impact of a missingdummyTrustManager
to help with future triage.