Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jvm.gc.old_gen_size as an alias for Tenured Gen #358

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

ogaca-dd
Copy link
Contributor

Add jvm.gc.old_gen_size as an alias for Tenured Gen.

Motivation:
SerialGC may be the default GC for openjdk 11.0.10 and it exposes Tenured Gen beans.

See AC-907.

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you've confirmed this works well!

About the name of this new metric: I was wondering if jvm.gc.old_gen_size was the right name or if we should use jvm.gc.tenured_gen_size, but apparently "tenured" and "old" are synonyms (according to https://stackoverflow.com/a/26462943 anyway), so using jvm.gc.old_gen_size makes sense for consistency with the other metrics 👍

@ogaca-dd ogaca-dd merged commit 008b5b2 into master Apr 14, 2021
@ogaca-dd ogaca-dd deleted the olivierg/tenured-gen branch April 14, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants