Statsd reporter to require host name and optional port to support UDS #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh123man
changed the title
olivielpeau
reviewed
Oct 16, 2020
Co-authored-by: Olivier Vielpeau <[email protected]>
…tch into brian/jmxfetch-support-uds
olivielpeau
reviewed
Oct 23, 2020
There was a problem hiding this comment.
LGTM overall, let's make sure we're entirely sure the origin detection is correctly disabled before merging this (see my comment on the other PR: DataDog/datadog-agent#6565 (review))
src/main/java/org/datadog/jmxfetch/reporter/StatsdReporter.java
Outdated
Show resolved
Hide resolved
truthbk
reviewed
Oct 27, 2020
gh123man
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 30, 2020
This PR enables JMXFetch to use UDS when configured. Since the rest of dogstatsd can use UDS instead of UDP, it makes sense for JMXFetch to also support this. Related JMXFetch PR: DataDog/jmxfetch#335 Co-authored-by: Jaime Fullaondo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables JMXFetch to use UDS as well as UDP connections for statsd.
I am introducing a breaking change to the statsd connection string. Now it will require a hostname whereas before the host was optional and it only required a port. Now the host is require and the port is optional. If no port number is found, JMXFetch assumes UDS.
I also rev'd the java-dogstatsd-client version