Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remoteconnection] if the port is a string, cast w/ parseInt(). #121

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Jan 27, 2017

This is an issue now giving the way service discovery on the dd-agent side populates the templates. Besides, customers can always make the mistake of putting quotes around a port number. This should be able to address that.

Copy link

@sjenriquez sjenriquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@truthbk truthbk merged commit 6bda58f into master Jan 27, 2017
@truthbk truthbk deleted the jaime/port_string branch January 27, 2017 17:36
@truthbk truthbk restored the jaime/port_string branch January 27, 2017 17:39
@truthbk truthbk deleted the jaime/port_string branch January 27, 2017 17:50
@olivielpeau olivielpeau added this to the 0.13.0 milestone Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants