-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Unix Domain Socket functionality optional #85
Comments
Another advantage of this is that
Many organisations won't be able to use this library at the moment because of that dependency (we currently can't upgrade past v2.5). |
deadok22
added a commit
to deadok22/java-dogstatsd-client
that referenced
this issue
May 26, 2023
As a workaround for DataDog#85, avoid loading jnr classes unless they are required. Do not perform the `instanceof UnixSocketAddress` check for resolvers that are known not to return UDS addresses. This change makes it possible for the library consumers that don't use UDS to exclude jnr-unixsocket and all of its transitive dependencies from their classpath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not all usages of the library need Unix Domain Socket transport. Let's figure out how to make it optional.
Some wins we can get by making Unix Domain Socket transport optional:
java-dogstatsd-client
only depends on JARs brought in bycom.github.jnr:jnr-unixsocket
. If we remove this dependency, projects not requiring Unix Domain Socket transport will have to import 1 JAR instead of 14.Some approaches we could take to address this:
com.github.jnr:jnr-unixsocket
an optional dependency and add some workarounds to prevent eager loading of classes from that JAR.The text was updated successfully, but these errors were encountered: