feat: Support Dogstatsd 1.1 protocol for distributions #216
Conversation
There is a new experimental Dogstatsd protocol (1.1) which supports sending multiple values in a single datagram. This is supported since agent 7.25.0/6.25.0. This evolution in the protocol allows clients to buffer histogram and distribution values and send them in fewer payload to the agent (providing a behavior close to client-side aggregation for those types). This commit add support for this new protocol for distribution. Fix DataDog#215
|
@vickenty do you have an idea why CircleCI is complaining as I have not touch anything related to it?
|
|
Hi @blemale , thank you for opening the PR, but I don't think this is the right way to do this: multi-valued payloads are not a feature that we expose directly to the users, but rather than an optimization that can be toggled on and off (via "client side aggregation"). For example, please see how datadog-go implements this: clients provide one sample at a time, which are then aggregated internally and sent as a multi-valued message. Serialization code should also take care to split values over several messages to avoid too big payloads. |
|
👋 Hi @vickenty ! Thanks for the insights :) Sadly, on the code base i'm working on, i.e DD logs-backend, we are not using the aggregation layer, i.e However every time we report a distribution we report 1 000 values, currently using I understand that this proposal goes a bit against the design of this library but |
There is a new experimental Dogstatsd protocol (1.1) which supports sending multiple values in a single datagram.
This is supported since agent 7.25.0/6.25.0.
This evolution in the protocol allows clients to buffer histogram and distribution values and send them in fewer payload to the agent (providing a behavior close to client-side aggregation for those types).
This commit add support for this new protocol for distribution.
Fix #215