Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kube_job tag to job metrics #9775

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add kube_job tag to job metrics #9775

merged 1 commit into from
Jul 27, 2021

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Adds kube_job tag, it takes the value of job_name.

Motivation

Match what the tag key used by the tagger

Additional Notes

fixes: DataDog/helm-charts#327

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ahmed-mez ahmed-mez requested review from a team as code owners July 27, 2021 08:58
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #9775 (202f8f1) into master (2085730) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.93% <ø> (ø)
kubernetes_state 89.69% <ø> (ø)
snmp 91.57% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ahmed-mez ahmed-mez merged commit 64f6d46 into master Jul 27, 2021
@ahmed-mez ahmed-mez deleted the ahmed/ksm-job-tag branch July 27, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infrastructure metrics and logs tags do not match
3 participants