Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow float value for timeout #9711

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Allow float value for timeout #9711

merged 1 commit into from
Jul 15, 2021

Conversation

coignetp
Copy link
Contributor

What does this PR do?

We allow float values for timeout in code

timeout = float(instance.get('timeout', 10))

But we converted it to int anyway with the config models https://pydantic-docs.helpmanual.io/usage/types/

Motivation

QA #8990

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #9711 (1d4750f) into master (26dd6f6) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
statsd 87.36% <ø> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorianVeaux FlorianVeaux merged commit b0643c3 into master Jul 15, 2021
@FlorianVeaux FlorianVeaux deleted the paul/statsd-float branch July 15, 2021 12:06
FlorianVeaux pushed a commit that referenced this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants