Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple DBM query metrics interval from check run interval #9658

Merged
merged 2 commits into from
Jul 9, 2021
Merged

decouple DBM query metrics interval from check run interval #9658

merged 2 commits into from
Jul 9, 2021

Conversation

djova
Copy link
Contributor

@djova djova commented Jul 8, 2021 •
edited
Loading

What does this PR do?

  • decouple the DBM metrics collection interval from the check run interval
  • set default DBM metrics collection interval to 10s
  • change statement_samples.collections_per_second to statement_samples.collection_interval so it matches the new statement_metrics.collection_interval key

Depends on #9656

Motivation

Being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@djova djova mentioned this pull request Jul 8, 2021
Merged
4 tasks
@djova djova changed the title Djova/dbm mysql decouple query metrics interval decouple DBM query metrics interval from check run interval Jul 8, 2021
djova added a commit that referenced this pull request Jul 8, 2021
@djova
add db.utils.DBMAsyncJob
064a664 
Adds a new `DBMAsyncJob` class which will be used by the `postgres` and `mysql` checks to schedule asynchronous tasks that need to run independently of the main check.

Follow-up PRs:
* postgres: #9657
* mysql: #9658
@djova djova force-pushed the djova/dbm-mysql-decouple-query-metrics-interval branch from a0423d2 to 9d31c7a Compare July 8, 2021 18:29
@codecov
Copy link

codecov bot commented Jul 8, 2021 •
edited
Loading

Codecov Report

Merging #9658 (ffe10f6) into master (b9849ce) will increase coverage by 0.01%.
The diff coverage is 92.15%.

Flag Coverage Δ
mysql 85.21% <92.15%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

djova added a commit that referenced this pull request Jul 8, 2021
@djova
add db.utils.DBMAsyncJob (#9656)
0113b0a 
Adds a new `DBMAsyncJob` class which will be used by the `postgres` and `mysql` checks to schedule asynchronous tasks that need to run independently of the main check.

Follow-up PRs:
* postgres: #9657
* mysql: #9658
@djova djova force-pushed the djova/dbm-mysql-decouple-query-metrics-interval branch 2 times, most recently from 9bde516 to ed5419d Compare July 8, 2021 19:26
@djova
decouple DBM query metrics interval from check run interval
5ac9c7c 
* decouple the DBM metrics collection interval from the check run interval
* set default DBM metrics collection interval to 10s
* change `statement_samples.collections_per_second` to `statement_samples.collection_interval` so it matches the new `statement_metrics.collection_interval` key

Depends on #9656

Motivation: being able to configure the DBM metrics collection interval separately from the check run interval enables us to use a 10 second interval (by default) for the query metrics. There are various difficulties when querying metrics that have a 15 second interval (i.e. ensuring a correct rollup window for varying time ranges) that don't exist with a 10 second interval.
@djova djova force-pushed the djova/dbm-mysql-decouple-query-metrics-interval branch from ed5419d to 5ac9c7c Compare July 8, 2021 19:27
@djova djova marked this pull request as ready for review July 8, 2021 19:27
@djova djova requested review from a team as code owners July 8, 2021 19:27
@djova djova requested a review from a team as a code owner July 8, 2021 19:40
@ghost ghost added the documentation label Jul 8, 2021
alexandre-normand
alexandre-normand approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@alexandre-normand alexandre-normand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@djova djova merged commit 8a8aa22 into master Jul 9, 2021
@djova djova deleted the djova/dbm-mysql-decouple-query-metrics-interval branch July 9, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@alexandre-normand alexandre-normand alexandre-normand approved these changes

Assignees
No one assigned
Labels
documentation integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djova @alexandre-normand @ofek