Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XDR metrics for Aerospike Enterprise 5.0+ #8696

Merged
merged 19 commits into from
Apr 6, 2021
Merged

Support XDR metrics for Aerospike Enterprise 5.0+ #8696

merged 19 commits into from
Apr 6, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

This PR supports for XDR metrics introduced in Aerospike 5.0+

Motivation

The dcs command was removed along with xdr_ metrics under the statistics command.
https://www.aerospike.com/docs/operations/configure/cross-datacenter/parameters_and_metrics.html#xdr-metrics-removed-in-version-5-0

Additional Notes

These metrics are Aerospike Enterprise only

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested a review from a team as a code owner February 25, 2021 19:36
@ChristineTChen ChristineTChen changed the title Support get_stats command Support XDR metrics for Aerospike Enterprise 5.0+ Feb 25, 2021
@ChristineTChen ChristineTChen requested a review from a team as a code owner February 25, 2021 23:26
@ghost ghost added the documentation label Feb 25, 2021
sarina-dd
sarina-dd previously approved these changes Feb 26, 2021
View reviewed changes
@ChristineTChen ChristineTChen requested a review from sarina-dd April 5, 2021 21:39
luisgonzalex
luisgonzalex previously approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@luisgonzalex luisgonzalex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice implementation and tests -- I think tests fail on CI though

@ChristineTChen ChristineTChen merged commit 543d1ee into master Apr 6, 2021
@ChristineTChen ChristineTChen deleted the cc/aerospike-xdr branch April 6, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisgonzalex luisgonzalex luisgonzalex approved these changes

@sarina-dd sarina-dd Awaiting requested review from sarina-dd

Assignees
No one assigned
Labels
documentation integration/aerospike
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @luisgonzalex @sarina-dd