Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newly documented metrics #7765

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Add newly documented metrics #7765

merged 2 commits into from
Oct 13, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 9, 2020

@ofek ofek requested a review from a team as a code owner October 9, 2020 16:59
@ghost ghost added the integration/envoy label Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020 •
edited
Loading

Codecov Report

Merging #7765 into master will increase coverage by 4.70%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
envoy/datadog_checks/envoy/metrics.py 100.00% <ø> (ø)
envoy/tests/test_envoy.py 100.00% <100.00%> (ø)
datadog_checks_dev/datadog_checks/dev/terraform.py
disk/tests/utils.py
amazon_msk/datadog_checks/amazon_msk/metrics.py
...cks/dev/tooling/configuration/consumers/example.py
...g_checks_base/datadog_checks/base/utils/tagging.py
active_directory/tests/test_active_directory.py
cockroachdb/datadog_checks/cockroachdb/metrics.py
kube_dns/tests/test_kube_dns.py
... and 456 more

yzhan289
yzhan289 reviewed Oct 9, 2020
View reviewed changes
envoy/datadog_checks/envoy/metrics.py
Comment on lines +3188 to +3189
(),
(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two extra (),?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each metric part has a tuple of 0 or more tags

FlorianVeaux
FlorianVeaux previously approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can't we test those using integration testing and e2e?

@ofek
Copy link
Contributor Author

ofek commented Oct 13, 2020

@FlorianVeaux Done!

@ofek ofek merged commit af543a4 into master Oct 13, 2020
@ofek ofek deleted the ofek/mem branch October 13, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 left review comments

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
integration/envoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @FlorianVeaux @yzhan289