Properly handle a parsing edge case #7717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
|
hithwen
reviewed
Oct 6, 2020
| @@ -41,6 +41,10 @@ def parse_metric(metric, metric_mapping=METRIC_TREE): | |||
| if metric_part in metric_mapping and num_tags >= minimum_tag_length: | |||
| # Rebuild any built up tags whenever we encounter a known metric part. | |||
| if tag_builder: | |||
| # Edge case where we hit a known metric part after a sequence of all unknown parts | |||
| if '|_tags_|' not in metric_mapping: | |||
| raise UnknownMetric | |||
There was a problem hiding this comment.
I thought this was not correct but seems that the PEP to make it incorrect got rejected https://www.python.org/dev/peps/pep-0317 :p
hithwen
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #7686
Additional Notes
A subsequent PR will add the new metrics