Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubernetes_state auto_conf.yaml with valid example configuration #7414

Merged
merged 3 commits into from
May 5, 2021

Conversation

jfmyers9
Copy link
Contributor

What does this PR do?

Tiny change to the example configuration in the auto_conf.yaml for kubernetes_state.

Motivation

I tried copying the example configuration and it didn't work. Had to read the code to figure out the correct value.

Additional Notes

No.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@jfmyers9 jfmyers9 requested review from a team as code owners August 21, 2020 16:03
@jfmyers9 jfmyers9 requested a review from clamoriniere August 28, 2020 21:54
@stale
Copy link

stale bot commented Oct 4, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity.

@stale stale bot added the stale label Oct 4, 2020
@stale stale bot removed the stale label May 4, 2021
@hithwen hithwen self-requested a review May 4, 2021 16:08
Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the example and default file: labels_to_match is replacing label_to_match

@hithwen hithwen merged commit db71ac7 into DataDog:master May 5, 2021
github-actions bot pushed a commit to rlaveycal/integrations-core that referenced this pull request May 5, 2021
…on (DataDog#7414)

* update kubernetes_state auto_conf.yaml with valid example configuration
* Update kubernetes_state/datadog_checks/kubernetes_state/data/auto_conf.yaml

Co-authored-by: Cedric Lamoriniere <[email protected]> db71ac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants