Handle server info for envoy <= 1.8 #6740

AlexandreYang · 2020-05-26T17:17:48Z

Handle server info for envoy <= 1.8

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
PR title must be written as a CHANGELOG entry (see why)
Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
PR must have changelog/ and integration/ labels attached

envoy/datadog_checks/envoy/envoy.py

Handle server info for envoy <= 1.8

9fe0298

github-actions bot added the integration/envoy label May 26, 2020

AlexandreYang added 3 commits May 26, 2020 19:19

Fix test

c22377d

use debug

2852718

fix typo

ce9dec9

AlexandreYang force-pushed the alex/envoy_fix_version branch from da86392 to ce9dec9 Compare May 26, 2020 17:39

update test

249165c

AlexandreYang marked this pull request as ready for review May 26, 2020 17:43

AlexandreYang requested a review from a team as a code owner May 26, 2020 17:43

ofek added the changelog/Fixed label May 26, 2020

clean up

4e36fca

ofek requested changes May 26, 2020

View reviewed changes

envoy/datadog_checks/envoy/envoy.py Show resolved Hide resolved

AlexandreYang added 2 commits May 26, 2020 20:08

Fix exception handling

e3e9c69

Fix regex

efba207

AlexandreYang requested a review from ofek May 26, 2020 18:26

ofek approved these changes May 26, 2020

View reviewed changes

AlexandreYang merged commit 22f24a3 into master May 26, 2020

AlexandreYang deleted the alex/envoy_fix_version branch May 26, 2020 18:39

ChristineTChen pushed a commit that referenced this pull request May 26, 2020

Handle server info for envoy <= 1.8 (#6740)

68305a4

Provide feedback