Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect version metadata #6595

Merged
merged 2 commits into from
May 7, 2020
Merged

Collect version metadata #6595

merged 2 commits into from
May 7, 2020

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented May 7, 2020

What does this PR do?

Retrieve envoy version and set the associated metadata.

Motivation

Additional Notes

The version is available at http://domain/thing/server_info, so it uses the stats_url attribute in the config file http://domain/thing/stats and transforms it. So there is no additional attribute in the configuration file, but it does not cover some edge cases.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner May 7, 2020 12:49
@coignetp coignetp self-assigned this May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

@coignetp coignetp changed the title WIP: Get envoy version metadata Get envoy version metadata May 7, 2020
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ofek ofek changed the title Get envoy version metadata Collect version metadata May 7, 2020
@coignetp coignetp merged commit df5e3e1 into master May 7, 2020
@coignetp coignetp deleted the paul/envoy-metadata branch May 7, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants