From 85828df3c2691f7cffc79da25822de8294ab42d1 Mon Sep 17 00:00:00 2001 From: Tony Han Date: Tue, 5 Nov 2019 11:18:39 +0800 Subject: [PATCH] Add new Envoy metrics for Redis These metrics are defined from 1.10.0 https://www.envoyproxy.io/docs/envoy/v1.10.0/configuration/network_filters/redis_proxy_filter#config-network-filters-redis-proxy --- envoy/datadog_checks/envoy/metrics.py | 24 ++++++++++++++++++++++++ envoy/metadata.csv | 11 +++++++++++ 2 files changed, 35 insertions(+) diff --git a/envoy/datadog_checks/envoy/metrics.py b/envoy/datadog_checks/envoy/metrics.py index 39497336c9fa6..ecd1df1041d6c 100644 --- a/envoy/datadog_checks/envoy/metrics.py +++ b/envoy/datadog_checks/envoy/metrics.py @@ -761,6 +761,30 @@ ), 'method': 'monotonic_count', }, + 'redis.command.success': { + 'tags': ( + ('stat_prefix', ), + ('command', ), + (), + ), + 'method': 'monotonic_count', + }, + 'redis.command.error': { + 'tags': ( + ('stat_prefix', ), + ('command', ), + (), + ), + 'method': 'monotonic_count', + }, + 'redis.command.latency': { + 'tags': ( + ('stat_prefix', ), + ('command', ), + (), + ), + 'method': 'histogram', + }, 'mongo.decoding_error': { 'tags': ( ('stat_prefix', ), diff --git a/envoy/metadata.csv b/envoy/metadata.csv index 1b86112447fb1..bebe24aefac01 100644 --- a/envoy/metadata.csv +++ b/envoy/metadata.csv @@ -80,6 +80,17 @@ envoy.redis.downstream_rq_total,count,,request,,Total requests,0,envoy, envoy.redis.splitter.invalid_request,count,,request,,Number of requests with an incorrect number of arguments,-1,envoy, envoy.redis.splitter.unsupported_command,count,,operation,,Number of commands issued which are not recognized by the command splitter,-1,envoy, envoy.redis.command.total,count,,operation,,Number of commands,0,envoy, +envoy.redis.command.success,count,,operation,,Number of commands that were successful,0,envoy, +envoy.redis.command.error,count,,operation,,Number of commands that returned a partial or complete error response,0,envoy, +envoy.redis.command.latency.0percentile,gauge,,millisecond,,Command execution time in milliseconds 0-percentile,-1,envoy, +envoy.redis.command.latency.25percentile,gauge,,millisecond,,Command execution time in milliseconds 25-percentile,-1,envoy, +envoy.redis.command.latency.50percentile,gauge,,millisecond,,Command execution time in milliseconds 50-percentile,-1,envoy, +envoy.redis.command.latency.75percentile,gauge,,millisecond,,Command execution time in milliseconds 75-percentile,-1,envoy, +envoy.redis.command.latency.90percentile,gauge,,millisecond,,Command execution time in milliseconds 90-percentile,-1,envoy, +envoy.redis.command.latency.95percentile,gauge,,millisecond,,Command execution time in milliseconds 95-percentile,-1,envoy, +envoy.redis.command.latency.99percentile,gauge,,millisecond,,Command execution time in milliseconds 99-percentile,-1,envoy, +envoy.redis.command.latency.99_9percentile,gauge,,millisecond,,Command execution time in milliseconds 99.9-percentile,-1,envoy, +envoy.redis.command.latency.100percentile,gauge,,millisecond,,Command execution time in milliseconds 100-percentile,-1,envoy, envoy.mongo.decoding_error,count,,error,,Number of MongoDB protocol decoding errors,-1,envoy, envoy.mongo.delay_injected,count,,occurrence,,Number of times the delay is injected,0,envoy, envoy.mongo.op_get_more,count,,message,,Number of OP_GET_MORE messages,0,envoy,