Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metrics for Redis #4946

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

tony612
Copy link
Contributor

@tony612 tony612 commented Nov 5, 2019

These metrics are defined from 1.10.0 https://www.envoyproxy.io/docs/envoy/v1.10.0/configuration/network_filters/redis_proxy_filter#config-network-filters-redis-proxy

What does this PR do?

Add support for Redis metrics in new(>=1.10) Envoy version

Motivation

The current version doesn't support these new metrics

Additional Notes

https://www.envoyproxy.io/docs/envoy/v1.10.0/configuration/network_filters/redis_proxy_filter#config-network-filters-redis-proxy

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@tony612 tony612 requested review from a team as code owners November 5, 2019 03:23
@tony612 tony612 force-pushed the envoy-redis-new-stats branch 2 times, most recently from a36a1d8 to 85828df Compare November 5, 2019 03:33
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tony612 Awesome job, thanks!

@ofek ofek changed the title Add new Envoy metrics for Redis Add new metrics for Redis Nov 5, 2019
@ofek ofek merged commit 0ed0f7b into DataDog:master Nov 5, 2019
@tony612 tony612 deleted the envoy-redis-new-stats branch November 5, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants