-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mesos_slave service check #4448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
AlexandreYang
force-pushed
the
alex/mesos_slave_api_logic
branch
2 times, most recently
from
August 28, 2019 08:59
b95cd17
to
1d07673
Compare
AlexandreYang
force-pushed
the
alex/mesos_slave_api_logic
branch
from
August 28, 2019 09:57
d47e009
to
08d03d7
Compare
AlexandreYang
added
changelog/Fixed
integration/mesos_slave
and removed
do-not-merge/WIP
labels
Aug 28, 2019
AlexandreYang
commented
Aug 28, 2019
AlexandreYang
changed the title
Fix mesos_master service check
Fix mesos_slave service check
Aug 28, 2019
…rations-core into alex/mesos_slave_api_logic
ofek
requested changes
Aug 28, 2019
Co-Authored-By: Ofek Lev <[email protected]>
…rations-core into alex/mesos_slave_api_logic
ofek
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Mesos service check + Add tests.
Fix for #4054
Long term solution
The service check logic should be outside of
_get_json
util method that is used multiple times.Currently, the logic is quite cumbersome because service check logic is inside the
_get_json
util method.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached