Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mesos_slave service check #4448

Merged
merged 17 commits into from
Aug 28, 2019
Merged

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Aug 28, 2019

What does this PR do?

Fix Mesos service check + Add tests.

Fix for #4054

Long term solution

The service check logic should be outside of _get_json util method that is used multiple times.
Currently, the logic is quite cumbersome because service check logic is inside the _get_json util method.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@AlexandreYang AlexandreYang requested a review from a team as a code owner August 28, 2019 07:16
@AlexandreYang AlexandreYang changed the title Fix Mesos service check [WIP] Fix Mesos service check Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

@AlexandreYang AlexandreYang force-pushed the alex/mesos_slave_api_logic branch 2 times, most recently from b95cd17 to 1d07673 Compare August 28, 2019 08:59
@AlexandreYang AlexandreYang force-pushed the alex/mesos_slave_api_logic branch from d47e009 to 08d03d7 Compare August 28, 2019 09:57
@AlexandreYang AlexandreYang changed the title [WIP] Fix Mesos service check Fix Mesos service check Aug 28, 2019
@AlexandreYang AlexandreYang changed the title Fix Mesos service check Fix mesos_master service check Aug 28, 2019
@AlexandreYang AlexandreYang changed the title Fix mesos_master service check Fix mesos_slave service check Aug 28, 2019
mesos_slave/tests/test_integration_e2e.py Outdated Show resolved Hide resolved
mesos_slave/tests/test_integration_e2e.py Show resolved Hide resolved
@AlexandreYang AlexandreYang merged commit 60223f4 into master Aug 28, 2019
@AlexandreYang AlexandreYang deleted the alex/mesos_slave_api_logic branch August 28, 2019 15:59
@AlexandreYang AlexandreYang mentioned this pull request Aug 28, 2019
6 tasks
ChristineTChen pushed a commit that referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants