Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__ method params #4243

Merged
merged 6 commits into from
Aug 5, 2019
Merged

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #4243 into master will decrease coverage by 3.16%.
The diff coverage is 86.66%.

Impacted file tree graph

Impacted Files Coverage Δ
harbor/datadog_checks/harbor/harbor.py 85.86% <100%> (ø) ⬆️
teamcity/datadog_checks/teamcity/teamcity.py 64.7% <100%> (ø) ⬆️
teamcity/tests/test_teamcity.py 97.43% <100%> (ø) ⬆️
fluentd/datadog_checks/fluentd/fluentd.py 91.11% <100%> (-0.38%) ⬇️
go_expvar/tests/conftest.py 100% <100%> (ø) ⬆️
fluentd/tests/conftest.py 100% <100%> (ø) ⬆️
go_expvar/datadog_checks/go_expvar/go_expvar.py 82.3% <100%> (ø) ⬆️
lighttpd/datadog_checks/lighttpd/lighttpd.py 79.26% <50%> (ø) ⬆️
riakcs/datadog_checks/riakcs/riakcs.py
oracle/tests/test_oracle.py
... and 704 more

.travis.yml Outdated Show resolved Hide resolved
@ChristineTChen ChristineTChen force-pushed the christine/cleanup-proxy branch from 10f32c3 to efe7cce Compare July 31, 2019 15:39
@ChristineTChen ChristineTChen force-pushed the christine/cleanup-proxy branch from efe7cce to 3fec271 Compare August 1, 2019 03:06
hithwen
hithwen previously approved these changes Aug 1, 2019
@ChristineTChen ChristineTChen merged commit 33db839 into master Aug 5, 2019
@ChristineTChen ChristineTChen deleted the christine/cleanup-proxy branch August 5, 2019 18:12
@DataDog DataDog deleted a comment from codecov bot Aug 29, 2019
@DataDog DataDog deleted a comment from codecov bot Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants