Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequestsWrapper to envoy #4120

Merged
merged 9 commits into from
Jul 26, 2019
Merged

Add RequestsWrapper to envoy #4120

merged 9 commits into from
Jul 26, 2019

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jul 15, 2019

Adds requests wrapper to envoy

@hithwen hithwen requested review from a team as code owners July 15, 2019 12:24
@hithwen hithwen force-pushed the julia/envoy-requests-wrapper branch 2 times, most recently from 30ce674 to 6eddbc9 Compare July 15, 2019 12:29
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #4120 into master will increase coverage by 6.91%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master    #4120      +/-   ##
==========================================
+ Coverage   86.96%   93.88%   +6.91%     
==========================================
  Files         749       13     -736     
  Lines       38785      605   -38180     
  Branches     4585       98    -4487     
==========================================
- Hits        33730      568   -33162     
+ Misses       3829       24    -3805     
+ Partials     1226       13    -1213

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #4120 into master will increase coverage by 6.91%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master    #4120      +/-   ##
==========================================
+ Coverage   86.96%   93.88%   +6.91%     
==========================================
  Files         749       13     -736     
  Lines       38785      605   -38180     
  Branches     4585       98    -4487     
==========================================
- Hits        33730      568   -33162     
+ Misses       3829       24    -3805     
+ Partials     1226       13    -1213

@hithwen hithwen force-pushed the julia/envoy-requests-wrapper branch from 6eddbc9 to a630540 Compare July 15, 2019 13:31
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, otherwise looks good.

envoy/datadog_checks/envoy/envoy.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add every option from #4094

envoy/datadog_checks/envoy/envoy.py Outdated Show resolved Hide resolved
@hithwen hithwen requested review from ofek and AlexandreYang July 23, 2019 15:45
AlexandreYang
AlexandreYang previously approved these changes Jul 24, 2019
ChristineTChen
ChristineTChen previously approved these changes Jul 24, 2019
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

envoy/datadog_checks/envoy/data/conf.yaml.example Outdated Show resolved Hide resolved
envoy/datadog_checks/envoy/data/conf.yaml.example Outdated Show resolved Hide resolved
envoy/datadog_checks/envoy/data/conf.yaml.example Outdated Show resolved Hide resolved
envoy/datadog_checks/envoy/data/conf.yaml.example Outdated Show resolved Hide resolved
envoy/datadog_checks/envoy/data/conf.yaml.example Outdated Show resolved Hide resolved
envoy/datadog_checks/envoy/data/conf.yaml.example Outdated Show resolved Hide resolved
@hithwen hithwen dismissed stale reviews from ChristineTChen and AlexandreYang via 311e5b5 July 25, 2019 10:21
@hithwen hithwen requested a review from ruthnaebeck July 25, 2019 10:22
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@hithwen hithwen merged commit 03a2c4e into master Jul 26, 2019
@hithwen hithwen deleted the julia/envoy-requests-wrapper branch July 26, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants