-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RequestsWrapper to envoy #4120
Conversation
30ce674
to
6eddbc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4120 +/- ##
==========================================
+ Coverage 86.96% 93.88% +6.91%
==========================================
Files 749 13 -736
Lines 38785 605 -38180
Branches 4585 98 -4487
==========================================
- Hits 33730 568 -33162
+ Misses 3829 24 -3805
+ Partials 1226 13 -1213 |
Codecov Report
@@ Coverage Diff @@
## master #4120 +/- ##
==========================================
+ Coverage 86.96% 93.88% +6.91%
==========================================
Files 749 13 -736
Lines 38785 605 -38180
Branches 4585 98 -4487
==========================================
- Hits 33730 568 -33162
+ Misses 3829 24 -3805
+ Partials 1226 13 -1213 |
6eddbc9
to
a630540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add every option from #4094
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs review
Co-Authored-By: ruthnaebeck <[email protected]>
311e5b5
Co-Authored-By: ruthnaebeck <[email protected]>
Co-Authored-By: ruthnaebeck <[email protected]>
Co-Authored-By: ruthnaebeck <[email protected]>
Co-Authored-By: ruthnaebeck <[email protected]>
Co-Authored-By: ruthnaebeck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for docs
Adds requests wrapper to envoy