Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Envoy upstream_rq_completed cluster metrics #3955

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

csssuf
Copy link
Contributor

@csssuf csssuf commented Jun 20, 2019

What does this PR do?

Add the following metrics to the Envoy integration:

  • cluster.upstream_rq_completed
  • cluster.canary.upstream_rq_completed
  • cluster.internal.upstream_rq_completed
  • cluster.external.upstream_rq_completed

Motivation

These metrics are published by Envoy but not exposed by Datadog, but are useful for calculating request success rates.

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@csssuf csssuf requested a review from a team as a code owner June 20, 2019 19:48
@hithwen hithwen requested a review from ofek June 21, 2019 08:35
@therve therve merged commit bfec66e into DataDog:master Jun 25, 2019
@therve
Copy link
Contributor

therve commented Jun 25, 2019

Thanks for your contribution!

@csssuf csssuf deleted the envoy-add-cluster-metrics branch June 25, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants