Add listeners metrics

[coignetp]

What does this PR do?

Add more metrics

Motivation

Customer request

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

• PR title must be written as a CHANGELOG entry (see why)
• Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
• PR must have changelog/ and integration/ labels attached
• Feature or bugfix must have tests
• Git history must be clean
• If PR adds a configuration option, it must be added to the configuration file.

[FlorianVeaux]

Looks good, one question though. The customer request was also to add metrics for cipher:

$ curl -s 127.0.0.1:8002/stats | grep listener.0.0.0.0_8443.ssl.ciphers
listener.0.0.0.0_8443.ssl.ciphers.AEAD-AES128-GCM-SHA256: 4
listener.0.0.0.0_8443.ssl.ciphers.AEAD-AES256-GCM-SHA384: 3
listener.0.0.0.0_8443.ssl.ciphers.ECDHE-RSA-AES128-GCM-SHA256: 2495
listener.0.0.0.0_8443.ssl.ciphers.ECDHE-RSA-AES128-SHA: 10471
listener.0.0.0.0_8443.ssl.ciphers.ECDHE-RSA-CHACHA20-POLY1305: 142

Any chance they could be added too?

[codecov]

Codecov Report

Merging #3922 into master will increase coverage by 7.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3922      +/-   ##
==========================================
+ Coverage   86.87%   93.93%   +7.06%     
==========================================
  Files         705       13     -692     
  Lines       36265      610   -35655     
  Branches     4336       98    -4238     
==========================================
- Hits        31505      573   -30932     
+ Misses       3557       24    -3533     
+ Partials     1203       13    -1190

[codecov]

Codecov Report

Merging #3922 into master will increase coverage by 7.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3922      +/-   ##
==========================================
+ Coverage   86.87%   93.93%   +7.06%     
==========================================
  Files         705       13     -692     
  Lines       36265      610   -35655     
  Branches     4336       98    -4238     
==========================================
- Hits        31505      573   -30932     
+ Misses       3557       24    -3533     
+ Partials     1203       13    -1190

[coignetp]

Fixed the customer request by adding ciphers. The issue was probably a typo here

integrations-core/envoy/datadog_checks/envoy/metrics.py

Line 1066 in 04be24a

'listener.ssl.cipher': {

. I leave it there (and in the metadata

integrations-core/envoy/metadata.csv

Line 112 in 04be24a

envoy.listener.ssl.cipher,count,,connection,,Total TLS connections that used cipher tag,0,envoy,

) not to have breaking changes.

[FlorianVeaux]

👍 I think we should be fine to remove it, as this metric is never emitted right? I've checked and there isn't any customer monitor relying on this metric.

[hithwen]

@FlorianVeaux thanks for checking!

[ofek]

🔥

[ofek]

@coignetp @FlorianVeaux No typo, when I did this it was different https://www.envoyproxy.io/docs/envoy/v1.5.0/configuration/listeners/stats