Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the prometheus example to use prometheus_url #2790

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Change the prometheus example to use prometheus_url #2790

merged 1 commit into from
Dec 19, 2018

Conversation

someword
Copy link
Contributor

The example prometheus config is not using the correct parameter name.

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@someword
Change the prometheus example to use prometheus_url
c307a78 
The example prometheus config is not using the correct parameter name.
@someword someword requested a review from a team as a code owner December 18, 2018 21:07
masci
masci approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@masci masci merged commit 204af12 into DataDog:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
community documentation integration/prometheus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@someword @masci