Change order of precedence of whitelist and blacklist for pattern filtering #2174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The order is now: apply whitelist, then apply blacklist on remaining set of elements
Motivation
The other way is really counter intuitive and confusing. For example, if you blacklist a single element, that doesn't appear in your original set, then no matter what you set as a whitelist, the filter will always return your entire set.
This can appear as a bug, but technically it is not since the metrics you whitelisted are here all right, and the ones you blacklisted aren't.
This should answer #1527 (comment)
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?