[mysql] add dbms_flavor tag to tell if the database is mysql or mariadb #18950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-weaver
previously approved these changes
Oct 30, 2024
sethsamuel
approved these changes
Nov 1, 2024
Comment on lines
+856
to
+859
| return dbm_instance.get('tags', []) + [ | ||
| 'server:{}'.format(common.HOST), | ||
| 'port:{}'.format(common.PORT), | ||
| 'dbms_flavor:{}'.format(MYSQL_FLAVOR.lower()), |
There was a problem hiding this comment.
Is it better to use f"" formatting? it's a little bit less verbose.
There was a problem hiding this comment.
f"" is more concise. i use the same .format syntax for consistency. we used .format in the past because f"" is python3 only. it's no longer a concern now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
dbms_flavortag to the mysql integration metrics and events. The tag can better support explain parsing due to different explain plan format between mysql and mariadb.Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged