Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump prometheus client library to 0.3.0 #1866

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Bump prometheus client library to 0.3.0 #1866

merged 1 commit into from
Jul 11, 2018

Conversation

mfpierre
Copy link
Contributor

@mfpierre mfpierre commented Jul 11, 2018 •
edited
Loading

What does this PR do?

Bump prometheus client library to 0.3.0

Motivation

0.3.0 contains a significant performance improvement in parsing speed (prometheus/client_python#282)

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

@mfpierre mfpierre requested a review from a team as a code owner July 11, 2018 09:22
gzussa
gzussa approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mfpierre mfpierre merged commit 78c2072 into master Jul 11, 2018
@mfpierre mfpierre deleted the mfpierre/update-prom-client branch July 11, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base integration/prometheus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfpierre @gzussa @CharlyF