Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly send tags for histograms #1741

Merged
merged 1 commit into from
Jun 14, 2018
Merged

properly send tags for histograms #1741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion envoy/datadog_checks/envoy/envoy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def check(self, instance):

try:
metric, tags, method = parse_metric(envoy_metric)
tags.extend(custom_tags)
except UnknownMetric:
if envoy_metric not in self.unknown_metrics:
self.log.debug('Unknown metric `{}`'.format(envoy_metric))
Expand All @@ -84,7 +85,6 @@ def check(self, instance):

try:
value = int(value)
tags.extend(custom_tags)
get_method(self, method)(metric, value, tags=tags)

# If the value isn't an integer assume it's pre-computed histogram data.
Expand Down