Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly send tags for histograms #1741

Merged
merged 1 commit into from
Jun 14, 2018
Merged

properly send tags for histograms #1741

merged 1 commit into from
Jun 14, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jun 14, 2018

Motivation

Exception handling occurred first

@ofek ofek added this to the 6.3 milestone Jun 14, 2018
@ofek ofek requested a review from a team as a code owner June 14, 2018 06:30
Copy link
Collaborator

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, looks like we "released" this with 1.2.0 so I think we need a changelog entry here.

@ofek ofek merged commit 6ef4f21 into master Jun 14, 2018
@ofek ofek deleted the ofek/fix-tags branch June 14, 2018 15:06
nmuesch pushed a commit that referenced this pull request Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants