[envoy][rbac] Rule prefix tags #17392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results94 tests 79 ✅ 1m 7s ⏱️ For more details on these failures, see this check. Results for commit 1031241. ♻️ This comment has been updated with latest results. |
thomasvnoort
force-pushed
the
thomas.vannoort/envoy-rbac-rule-prefix-tags
branch
from
493bca8 to
217dac7
Compare
thomasvnoort
force-pushed
the
thomas.vannoort/envoy-rbac-rule-prefix-tags
branch
6 times, most recently
from
2ed09ec to
f918d56
Compare
thomasvnoort
force-pushed
the
thomas.vannoort/envoy-rbac-rule-prefix-tags
branch
from
f918d56 to
1031241
Compare
iliakur
reviewed
Apr 24, 2024
thomasvnoort
force-pushed
the
thomas.vannoort/envoy-rbac-rule-prefix-tags
branch
from
32b951e to
b8beb8b
Compare
iliakur
approved these changes
May 23, 2024
Kyle-Neale
approved these changes
May 23, 2024
steveny91
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for the
rule_stat_prefixoption of Envoy's RBAC metrics with therule_prefixtag, as implemented in envoyproxy/envoy#31835. This is not released yet, but will be included in an upcoming 1.30 Envoy release. Since this prefix is optional, we can add support for this here before the release is out.This PR also fixes a missing tagTIL the parser "inherits" tags across metrics of the same prefix, so it wasn't missing I was just misunderstanding the implementation of the legacy parser. Because of this, we also had to add a workaround since it couldn't parse different tags for the rule_prefix and shadow_rule_prefix; you had to pick one for all http.rbac metrics. This means we either had to use the same existing shadow_rule_prefix tag for normal metrics or make a breaking change to use rule_prefix for shadow metrics. Luckily, @steveny91 found a way to rewrite the tags after parsing to allow different prefix tags for normal and shadow metrics.shadow_rule_prefixon theshadow_allowedmetric which was omitted in #16453.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged