Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing custom tags to the can_connect service check #17194

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add missing custom tags to the can_connect service check #17194

merged 1 commit into from
Mar 15, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Mar 15, 2024 •
edited
Loading

What does this PR do?

Add missing custom tags to the can_connect service check

Motivation

#17188

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret force-pushed the florentclarret/harbor/service_checks_tags branch from de33890 to 8590ef3 Compare March 15, 2024 10:14
@FlorentClarret FlorentClarret added this to the 7.53.0 milestone Mar 15, 2024
@FlorentClarret FlorentClarret marked this pull request as ready for review March 15, 2024 10:24
@FlorentClarret FlorentClarret requested a review from a team as a code owner March 15, 2024 10:24
@FlorentClarret FlorentClarret mentioned this pull request Mar 15, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.27%. Comparing base (7aea63e) to head (8590ef3).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
harbor 89.65% <83.33%> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link

Test Results

12 files  12 suites   4m 12s ⏱️
11 tests 11 ✅ 0 💤 0 ❌
72 runs  66 ✅ 6 💤 0 ❌

Results for commit 8590ef3.

@FlorentClarret FlorentClarret merged commit 60818e2 into master Mar 15, 2024
39 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/harbor/service_checks_tags branch March 15, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliakur iliakur iliakur approved these changes

Assignees
No one assigned
Labels
integration/harbor team/agent-integrations
Projects
None yet
Milestone
7.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentClarret @iliakur